Adar Dembo has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4949/1//COMMIT_MSG Commit Message: PS1, Line 13: recipient What does "recipient" mean in this context? If you mean a destination tserver, every flush has one (or more) of those, so you must mean something else, right? Line 18: List<OperationResponses which switches us from the _errback_ to the _callback_ Nit: missing a '>' here. PS1, Line 26: make it Nit: make it fail? PS1, Line 26: fixing So this patch fixes the test? Or makes it fail more often? I don't see how it'd be possible to do both. Maybe reword this paragraph to clarify. http://gerrit.cloudera.org:8080/#/c/4949/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: PS1, Line 664: // We send the callback second so that the error collector's count becomes visible first, : // since calling callback will wake up whoever is waiting right away and having the error : // missing in the collector could be confusing. Nit: makes sense, but can we reword for terseness? Maybe: // Fire the callback after collecting the error so that the error is visible should the callback interrogate the error collector. -- To view, visit http://gerrit.cloudera.org:8080/4949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie871cde658036d04b9c07a3efe2fdfb4a7e98273 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
