Alexey Serbin has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4949/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: PS3, Line 684: e instanceof KuduException nit: how fast does this work? I.e., does it make sense to call this once and remember the result as a boolean and then re-use the result instead of calling this again and again? http://gerrit.cloudera.org:8080/#/c/4949/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java: PS1, Line 578: getTabletServerError nit: may be, buildTabletServerError() or makeTabletServerError() would be more appropriate for the name of this method? -- To view, visit http://gerrit.cloudera.org:8080/4949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie871cde658036d04b9c07a3efe2fdfb4a7e98273 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
