Adar Dembo has posted comments on this change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS1, Line 3641: gscoped_ptr Nit: unique_ptr for new stuff. Line 3646: ASSERT_OK(schema_builder.Build(&schema)); Interesting; why didn't we fail here instead? Line 3650: .num_replicas(3) Can be omitted, I think. -- To view, visit http://gerrit.cloudera.org:8080/4984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib508dbfbfd574c7c8ccc90ef8c3a41dcbfea058f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
