Todd Lipcon has posted comments on this change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 3646: ASSERT_OK(schema_builder.Build(&schema)); > Interesting; why didn't we fail here instead? I don't think the client should be the one responsible for checking the validity of type/encoding pairs, since eg then we'd need to update the client when the server starts to support RLE for int64, but maybe the client is talking to an old server which doesn't support it. -- To view, visit http://gerrit.cloudera.org:8080/4984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib508dbfbfd574c7c8ccc90ef8c3a41dcbfea058f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
