Mike Percy has posted comments on this change.

Change subject: KUDU-1735. Fix crash when aborting a skipped config change round
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Added a nit but the change looks good

http://gerrit.cloudera.org:8080/#/c/4916/3/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 237:       pending_(Substitute("T $0 P $1 ", options.tablet_id, 
peer_uuid)),
nit: maybe we should add ": " instead of " "


-- 
To view, visit http://gerrit.cloudera.org:8080/4916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4e4eb1d60ef66527edf33357fabc22f4b5b32f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to