Todd Lipcon has posted comments on this change. Change subject: KUDU-1735. Fix crash when aborting a skipped config change round ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4916/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS2, Line 610: -> > man that's a lot of arrows. maybe we could just get the mutable pointer bel Done http://gerrit.cloudera.org:8080/#/c/4916/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 237: pending_(Substitute("T $0 P $1 ", options.tablet_id, peer_uuid)), > nit: maybe we should add ": " instead of " " changed to ": " PS3, Line 619: const RaftConfigPB& new_config = change_record.new_config(); > I forget: do we have checks somewhere that the new config has a higher term the config only stores its index, and yea there are already checks to ignore it if it has a lower index -- To view, visit http://gerrit.cloudera.org:8080/4916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b4e4eb1d60ef66527edf33357fabc22f4b5b32f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
