Todd Lipcon has posted comments on this change. Change subject: KUDU-100 enable the ability to use RLE for the int64 type ......................................................................
Patch Set 1: (2 comments) Can you also edit encoding-test to add a test for int64s? it has 'TestIntBlockRoundTrip' which also includes support for generating runs. You'll also need to change the random() call in that function to generate 64-bit numbers (random() returns only 32-bit random integers). We have a different RNG available in util/random.h that you could use (it has a function for generating 64-bit rands i think) http://gerrit.cloudera.org:8080/#/c/4946/1/src/kudu/cfile/cfile-test-base.h File src/kudu/cfile/cfile-test-base.h: Line 221: return value * 10; this will never generate any integers which use all 64 bits. I think multiplying by some large number like 0x123456789abcdefLL in order to fill out all the bits would probably be a good idea. Line 230: return (value * 10) *(value % 2 == 0 ? -1 : 1); same -- To view, visit http://gerrit.cloudera.org:8080/4946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36ca437fcf0c98b3d79f7c07d72c1a7e61ff6a2f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Haijie Hong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
