Todd Lipcon has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4990/5/src/kudu/security/init.cc File src/kudu/security/init.cc: PS5, Line 88: krb5_creds creds > My guess is the issue is that this code is only run by external minicluster OK, new revision adds a test case which uses this new function outside of a minicluster, and it exposed the leak (which I then fixed as you suggested) PS5, Line 112: "KRB5CCNAME" > will do actually I think I'll do this in a follow-up since this patch is already a bit sprawling. adding a TODO. -- To view, visit http://gerrit.cloudera.org:8080/4990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I708334cbbee35d2629a38a369e63c1dc309ed91b Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
