Todd Lipcon has posted comments on this change.

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................


Patch Set 6:

(1 comment)

lgtm minus the nit on the comments.

Did you verify through looking at the jenkins logs that the tests are running 
as expected?

http://gerrit.cloudera.org:8080/#/c/5059/6/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 63: #     Build and test the Python wrapper of the client API in Python 
3.4.
this isn't explicitly picking python3.4, it's just whatever python3 is on the 
path, right?

Might be worth adding a line noting that this isn't mutually exclusive with 
BUILD_PYTHON and that we'll run both if they're both set.


-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to