Alexey Serbin has posted comments on this change. Change subject: KUDU-1745. Avoid crashing during failed master lookup ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5089/1/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: PS1, Line 151: server != nullptr Does it make sense to log something in the other case or we expect it would just crash somewhere in the call chain? -- To view, visit http://gerrit.cloudera.org:8080/5089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a06c31c5ad4e26928a7fcabf24f9fd7a02a7e38 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
