Todd Lipcon has posted comments on this change.

Change subject: KUDU-1745. Avoid crashing during failed master lookup
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5089/2/src/kudu/integration-tests/client_failover-itest.cc
File src/kudu/integration-tests/client_failover-itest.cc:

Line 222:   TestWorkload workload(cluster_.get());
> Couple questions about the workload:
will clean these items up.


Line 229:   SleepFor(MonoDelta::FromSeconds(1));
> Why is this needed?
Need to get the tablet server successfully looked up before crashing the 
servers. Otherwise the bug wasn't triggering. I'll add a comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/5089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a06c31c5ad4e26928a7fcabf24f9fd7a02a7e38
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to