Adar Dembo has posted comments on this change. Change subject: KUDU-1634 (part 2). Fixed bug which fails to ignore tmp consensus log segments ......................................................................
Patch Set 1: (1 comment) Agreed that the TSAN failure is not due to your change. You can ignore it. http://gerrit.cloudera.org:8080/#/c/5122/1/src/kudu/consensus/log_util.cc File src/kudu/consensus/log_util.cc: Line 810: if (fname.find(kTmpInfix) != fname.npos) { If I'm understanding the code in Log::CreatePlaceholderSegment() correctly, the temp files will be created with the name ".tmp.newsegmentXXXXXX" where XXXXXX has been replaced by mkstemp() in some way. So maybe we don't need this check at all, since the HasPrefixString() on L804 will find these "hidden" files? Or is this check intended to capture other temp files rather than just temporary log segments? -- To view, visit http://gerrit.cloudera.org:8080/5122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf25fbe6ecfc28aed9443cdfb6fb56100394c73 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
