Maxim Smyatkin has posted comments on this change. Change subject: KUDU-1634 (part 2). Fixed bug which fails to ignore tmp consensus log segments ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5122/1/src/kudu/consensus/log_util.cc File src/kudu/consensus/log_util.cc: Line 810: if (fname.find(kTmpInfix) != fname.npos) { > If I'm understanding the code in Log::CreatePlaceholderSegment() correctly, Hm, you're right, the .tmp.newsegmentXXXXXX files won't pass the previous check. But whether there may be any different tmp files or not, I'm not sure. Maybe the whole check is really unnecessary. Will check it later. -- To view, visit http://gerrit.cloudera.org:8080/5122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf25fbe6ecfc28aed9443cdfb6fb56100394c73 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Maxim Smyatkin <[email protected]> Gerrit-HasComments: Yes
