Alexey Serbin has posted comments on this change.
Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}()
......................................................................
Patch Set 2:
> Was this more for parity's sake or did you need this exposed? The
> libkudu_client module really just exposes the external signatures
> to python so if you want this to be exposed in the client it would
> need to be implemented in the PartialRow class in client.pyx.
> However, given the way python handles the semantics for PartialRows
> (schema.new_row({'foo': 'bar'} or alternatively row['foo'] = 'bar'
Yes, that was more about parity and also updating the stale comment about the
SetString/SetBinary -- those changed their sematics.
--
To view, visit http://gerrit.cloudera.org:8080/5114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If73894c3037f1158cf7b9d3aafecd228a0204bbd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No
