Alexey Serbin has posted comments on this change.
Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}()
......................................................................
Patch Set 2:
> didnt finish my sentence above...given the way python handles the
> semantics for PartialRows, im not sure if theres any way to deal
> with the NoCopy setters, also not 100% sure what effect python GC
> would have on using a NoCopy setter.
Well, supposedly it does the same thing as it did for old semantics of
SetString/SetBinary -- prior to 48766a4ce17d422ced9a6ec78c9a9969ac44d8c9 they
were not copying data. Basically, older Set{String,Binary} behaved like
current Set{String,Binary}NoCopy.
If you think it requires additional clarification -- sure, let's do that. I
just assumed that since it worked for Set{String,Binary} before, it's going to
work for Set{String,Binary}NoCopy now.
--
To view, visit http://gerrit.cloudera.org:8080/5114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If73894c3037f1158cf7b9d3aafecd228a0204bbd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No
