David Ribeiro Alves has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4993/2/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 619: // If the row has a DELETE redo which is older than ahm, is_garbage_collected is set to true. > Shouldn't this be in the header file? I also found this comment confusing, you mean the comment? done. the variable name is the same as it was previously in ApplyMutationsAndGenerateUndos. it means that the row is garbage collected and shouldn't be output in the compaction output. I moved the relevant comment from that method here (to the header of this method, that is). -- To view, visit http://gerrit.cloudera.org:8080/4993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e4bbb1cac68474756ea1716cfc4c5420cf503e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
