David Ribeiro Alves has submitted this change and it was merged. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation ......................................................................
Don't do UNDO garbage collection until after the REDO->UNDO transformation Reasoning about what has been garbage collected and not while at the same time generating UNDOs is tricky. Particularly taking REINSERTS into account and multiple row versions merging (part of a follow up patch). This moves UNDO garbage collection to after the transformation and simplifies things a bit, at the cost of some extra work. Change-Id: I10e4bbb1cac68474756ea1716cfc4c5420cf503e Reviewed-on: http://gerrit.cloudera.org:8080/4993 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: David Ribeiro Alves <[email protected]> --- M src/kudu/tablet/compaction.cc M src/kudu/tablet/compaction.h M src/kudu/tablet/delta_compaction.cc 3 files changed, 72 insertions(+), 96 deletions(-) Approvals: David Ribeiro Alves: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10e4bbb1cac68474756ea1716cfc4c5420cf503e Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
