Todd Lipcon has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param ......................................................................
Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/4928/10/src/kudu/common/row_changelist.cc File src/kudu/common/row_changelist.cc: Line 171: RowChangeListEncoder* out) { probably should DCHECK that 'out' is uninitialized if that's the intention here http://gerrit.cloudera.org:8080/#/c/4928/10/src/kudu/common/row_changelist.h File src/kudu/common/row_changelist.h: PS10, Line 359: // The buffer will be cleared before adding the result and will be empty if the projection : // ends up producing an empty RowChangeList. : this comment needs to be updated -- probably should mention whether 'out' should already have its type set, or be uninitialized -- To view, visit http://gerrit.cloudera.org:8080/4928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6584b22662b58227a80eaebb7d89199d3ea2498a Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
