Alexey Serbin has posted comments on this change. Change subject: KUDU-1189 if not set, use timestamp from first server ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5143/3/src/kudu/integration-tests/consistency-itest.cc File src/kudu/integration-tests/consistency-itest.cc: PS3, Line 360: ServerAssignedScanTimestamp > That I haven't verified yet. Will do and report on my findings. Good idea I checked that the test 100% fails it not adding the part for scanner-internal.cc: /home/aserbin/Projects/kudu/src/kudu/integration-tests/consistency-itest.cc:458: Failure Value of: row_count Actual: 2 Expected: 1UL Which is: 1 [ FAILED ] ConsistencyITest.TestSnapshotScanTimestampReuse (513 ms) The second scenario also fails 100%: /home/aserbin/Projects/kudu/src/kudu/integration-tests/consistency-itest.cc:522: Failure Value of: cfg.has_snapshot_timestamp() Actual: false Expected: true -- To view, visit http://gerrit.cloudera.org:8080/5143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ac708e38b8a80834f7d54eca294517cbfb06ec6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
