Alexey Serbin has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set ......................................................................
Patch Set 5: (2 comments) > (2 comments) > > any way we can add simple unit test for this? OK, I'll add a small unit test for that. http://gerrit.cloudera.org:8080/#/c/5143/5//COMMIT_MSG Commit Message: PS5, Line 7: scans: reuse snapshot timestamp when not set > How about: On READ_AT_SNAPSHOT scans, reuse timestamp from first server whe Too long: far more than 50 symbols :) We have the explanation in the details. The header should be concise, preferably to fit 50 symbols. That's per http://kudu.apache.org/docs/contributing.html, the 'generic git commit guidelines and good practices' link. Which is effectively: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines Line 11: for following scans > missing period Done -- To view, visit http://gerrit.cloudera.org:8080/5143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ac708e38b8a80834f7d54eca294517cbfb06ec6 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
