Dan Burkert has posted comments on this change.

Change subject: [java-client]: support for Kerberized RPC
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5150/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 313:       processBuilder.environment().putAll(miniKdc.getEnvVars());
> does this mean that every tserver is sharing the same KRB5CCNAME? doesn't s
Yes, all servers share the same KRB5CCNAME and keytab.  This is how the C++ 
external mini cluster works at the moment, from what I can tell (except that 
this only does one service login, whereas the C++ side inits the same service 
principal repeatedly).


http://gerrit.cloudera.org:8080/#/c/5150/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java:

Line 80:         assertTrue(cluster.waitForTabletServers(NUM_TABLET_SERVERS));
> does this end up making RPCs underneath?
Yes


-- 
To view, visit http://gerrit.cloudera.org:8080/5150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5131edb1f2bda443f7980a4aad86362666b3b6f5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to