Todd Lipcon has posted comments on this change. Change subject: [java-client]: support for Kerberized RPC ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5150/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 948: * Gets the subject who created the Kudu client. would be worth specifying somewhere (maybe here, maybe in the builder.build() javadoc) at what point the subject-capturing happens. eg is it when the builder is created or when the client is built? http://gerrit.cloudera.org:8080/#/c/5150/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: Line 313: processBuilder.environment().putAll(miniKdc.getEnvVars()); does this mean that every tserver is sharing the same KRB5CCNAME? doesn't seem quite what we want to avoid cross-process polution http://gerrit.cloudera.org:8080/#/c/5150/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java: Line 80: assertTrue(cluster.waitForTabletServers(NUM_TABLET_SERVERS)); does this end up making RPCs underneath? -- To view, visit http://gerrit.cloudera.org:8080/5150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5131edb1f2bda443f7980a4aad86362666b3b6f5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
