Alexey Serbin has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5188/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: PS6, Line 650: Server-assigned timestamp for the scan operation. It's used when : * the scan operates in READ_AT_SNAPSHOT mode and the timestamp is not : * specified explicitly. The field is set with the snapshot timestamp sent : * in the response from the very first tablet server contacted while : * fetching data from corresponding tablets. If the tablet server does not : * send the snapshot timestamp in its response, this field is assigned : * a special value AsyncKuduClient.NO_TIMESTAMP. > isn't it that the server always returns a scan timestamp, even if the user If so, then it contradicts with the comment for $REPO_ROOT/src/kudu/tserver/tserver.proto, line 342. I.e., the scan timestamp should be present only in response to those NewScanRequestPB messages, if I'm not mistaken. Sure, the test that you are describing makes sense, but I don't think that should be a unit test for the Java client. I think it would be better to have such a test among those in $REPO_ROOT/src/kudu/integration-tests directory. -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7207672f7b0cf1307bfa861bda3291b278618016 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
