Alexey Serbin has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5188/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: PS6, Line 650: Server-assigned timestamp for the scan operation. It's used when : * the scan operates in READ_AT_SNAPSHOT mode and the timestamp is not : * specified explicitly. The field is set with the snapshot timestamp sent : * in the response from the very first tablet server contacted while : * fetching data from corresponding tablets. If the tablet server does not : * send the snapshot timestamp in its response, this field is assigned : * a special value AsyncKuduClient.NO_TIMESTAMP. > maybe I didn't explain myself correctly. It was not about adding a new test If I understood correctly, then the check is there already: see TestScannerMultiTablet.java, line 218 The assertEquals() at that line check that the scan timestamp stays the same for all batches received from tablet servers. It covers the scenario you described. May be, I miss something here? -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7207672f7b0cf1307bfa861bda3291b278618016 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
