Adar Dembo has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" ......................................................................
Patch Set 2: (2 comments) Looks good to me, modulo two small things. I'll defer to Mike for the +2. http://gerrit.cloudera.org:8080/#/c/5191/1//COMMIT_MSG Commit Message: PS1, Line 9: This change makes the default action of 'local_replica delete' : tool to tombstone the tablet. > Adar, fyi what we shipped in 1.1 was a tool allowing the deletion via '--cl I see. Can you reword this paragraph then, to make the (lack of a semantic) change more clear? http://gerrit.cloudera.org:8080/#/c/5191/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: PS2, Line 180: s = Status::Corruption( : Substitute("Corruption detected in log segment: $0", s.ToString())); Why do we rewrite 's' in this case? Why not return it as-is during RETURN_NOT_OK() on L185? -- To view, visit http://gerrit.cloudera.org:8080/5191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia773de475431eb85fb0dbe724d524e8dd59b1b12 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
