Mike Percy has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 198: nit: spurious line Line 241: // Fallthrough intended. use FALLTHROUGH_INTENDED macro instead Line 256: } better to break at the end of the case http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/consensus/consensus_peers.h File src/kudu/consensus/consensus_peers.h: Line 62: ERROR, maybe this would be better named TIMED_OUT ? http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2609: LOG(WARNING) << "TS " << target_ts_desc_->ToString() Would be better to use the standard prefix T <tablet-id> P <peer-uuid> for these log messages here and below http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/tserver/tablet_server_test_util.cc File src/kudu/tserver/tablet_server_test_util.cc: Line 27: DEFINE_int32(num_updater_threads, 1, "Number of updating threads to launch"); Why put this stuff in this file? Maybe you need to create a new tablet_server-test-base.cc file? http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 213: boost::optional<TabletServerErrorPB::Code>* error_code); Why optional<>* ? New param needs doc -- To view, visit http://gerrit.cloudera.org:8080/5111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d3f84fd297a8e4760208a213c1ee393e92499a3 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
