Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2609: const scoped_refptr<TabletInfo>& tablet, > Would be better to use the standard prefix T <tablet-id> P <peer-uuid> for This change is moved to different patch, addressing it there. http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 213: // Open a tablet meta from the local file system by loading its superblock. > Why optional<>* ? New param needs doc Since this change moved to a different patch, I have addressed it there. http://gerrit.cloudera.org:8080/5352 -- To view, visit http://gerrit.cloudera.org:8080/5111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d3f84fd297a8e4760208a213c1ee393e92499a3 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
