Todd Lipcon has posted comments on this change. Change subject: Update debug partition and row printing ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5262/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: PS1, Line 585: if (partition.hash_buckets_.size() != hash_bucket_schemas_.size()) { : return "<hash-partition-error>"; : } should this be a CHECK? would be indicative of programmer error, right? or perhaps a LOG(DFATAL) at least so we'd catch it in test builds? Line 621: components.emplace_back(Substitute("<hash-error: $0>", s.ToString())); same Line 652: return "<hash-decode-error>"; same PS1, Line 689: oakc not following this reference Line 706: return "<range-key-decode-error>"; same Line 810: ColumnIdsToColumnNames(schema, hash_bucket_schema.column_ids)); for these HTML output functions, we should be escaping the user-provided column names -- To view, visit http://gerrit.cloudera.org:8080/5262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c444b155fe6621af65b86020be105fe56ae18ef Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
