David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ......................................................................
Patch Set 20: (5 comments) http://gerrit.cloudera.org:8080/#/c/4995/20/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: PS20, Line 625: int > this should be a sized int type, no? Done Line 664: // Expecte an UNDO reinsert for the delete. > typo Done http://gerrit.cloudera.org:8080/#/c/4995/20/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: PS20, Line 233: 0; > nit: should be a '.' Done PS20, Line 658: OrNull( > I think 'OrNull' is confusing here, because you're not advancing "while it' Done PS20, Line 669: head = right; : return head; > why not just 'return right;' (same below) Done -- To view, visit http://gerrit.cloudera.org:8080/4995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1173b2bea721b376f2b6049be20f57307582c47 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
