Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ......................................................................
Patch Set 20: (6 comments) http://gerrit.cloudera.org:8080/#/c/4995/20/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: PS20, Line 625: int this should be a sized int type, no? Line 664: // Expecte an UNDO reinsert for the delete. typo http://gerrit.cloudera.org:8080/#/c/4995/12/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 90: row_block_.reset(new RowBlock(iter_->schema(), num_in_block, &arena_)); > I guess not really since we don't do flushing compactions (where we would n well, it avoids an extra bit of copying, right? http://gerrit.cloudera.org:8080/#/c/4995/20/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: PS20, Line 233: 0; nit: should be a '.' PS20, Line 658: OrNull( I think 'OrNull' is confusing here, because you're not advancing "while it's null". I think you can just remove it, since it's kind of implicit that we won't advance past the end of the linked list. PS20, Line 669: head = right; : return head; why not just 'return right;' (same below) -- To view, visit http://gerrit.cloudera.org:8080/4995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1173b2bea721b376f2b6049be20f57307582c47 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
