Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5273
to review the following change.
Change subject: [c++] ColumnPredicate simplification for inequalities on
boundary values
......................................................................
[c++] ColumnPredicate simplification for inequalities on boundary values
Adds special casing for inequality predicates on minimum and maximum
values. This tightens partition pruning in boundary cases. New tests are
added to cover the specific transormations. We already have good test
coverage of boundary values in predicate-test.
These changes uncovered a bug in type traits where the minimum value for
float types was defined as the lowest discrete value instead of
-infinity, after adding the predicate simplification mutliple test cases
in predicate-test failed.
Change-Id: I9bb150249a51a69fb85af67d34e85b7d7bed325c
---
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
5 files changed, 184 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/5273/1
--
To view, visit http://gerrit.cloudera.org:8080/5273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bb150249a51a69fb85af67d34e85b7d7bed325c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
