Dan Burkert has submitted this change and it was merged. Change subject: [c++] ColumnPredicate simplification for inequalities on boundary values ......................................................................
[c++] ColumnPredicate simplification for inequalities on boundary values Adds special casing for inequality predicates on minimum and maximum values. This tightens partition pruning in boundary cases. New tests are added to cover the specific transformations. We already have good test coverage of boundary values in predicate-test. These changes uncovered a bug in type traits where the minimum value for float types was defined as the lowest discrete value instead of -infinity, after adding the predicate simplification multiple test cases in predicate-test failed. Change-Id: I9bb150249a51a69fb85af67d34e85b7d7bed325c Reviewed-on: http://gerrit.cloudera.org:8080/5273 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/common/column_predicate-test.cc M src/kudu/common/column_predicate.cc M src/kudu/common/partition_pruner-test.cc M src/kudu/common/types.cc M src/kudu/common/types.h 5 files changed, 184 insertions(+), 12 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bb150249a51a69fb85af67d34e85b7d7bed325c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
