David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset ......................................................................
Patch Set 17: Code-Review+1 (5 comments) just a rebase, keeping todd's +1 http://gerrit.cloudera.org:8080/#/c/4994/13/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: Line 618: { > Is it important that we do not roll? yeah, we want a single rowset, not that these rows would fill one, but this way we're sure and we dont have to make assertion on the number of the resulting rowsets. http://gerrit.cloudera.org:8080/#/c/4994/13/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: Line 113: // Get the latest mutation. > Consider writing this like: Done. Its unlikely that the we have both a redo head and that it's timesatmp is the same as the insertion timestamp, right. If for nothing else I think it has documentation value. Line 114: const Mutation* latest = input_row.redo_head; > nit: punctuation Done Line 117: latest->timestamp() == insertion_timestamp) { > similarly, consider writing this like: Done Line 134: block->resize(next_row_index); > Maybe better written as: Done -- To view, visit http://gerrit.cloudera.org:8080/4994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab52a1aa68494218f91f3acd31ef8ddf352bd57 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
