David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/11/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: PS11, Line 63: // This can only be applied to mutation lists that are not in a memory store. > can you explain why? actually this disappeared in the next patch so I removed it. -- To view, visit http://gerrit.cloudera.org:8080/4994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab52a1aa68494218f91f3acd31ef8ddf352bd57 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
