Todd Lipcon has posted comments on this change. Change subject: KUDU-1551. Ignore log segments which were preallocated but have no header. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5276/2/src/kudu/consensus/log_reader.cc File src/kudu/consensus/log_reader.cc: Line 146: if (s.IsUninitialized()) { > Do these segments get deleted? we re-write all the log segments during playback, and then delete the old directory, so yes, but not in an explicit way. http://gerrit.cloudera.org:8080/#/c/5276/2/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 206: // Enable the fault point after creating the table, but before writing any data. > Why is it important to do enable the fault after table creation? If it's do yep. PS2, Line 212: MonoDelta::FromSeconds(30) > Is this going to be enough time on ASAN/TSAN? I think so, since I set the roll size to 1MB. It's sub-second on a debug build, so I'd guess that even on ASAN/TSAN it would only be a few seconds. I'll double check. -- To view, visit http://gerrit.cloudera.org:8080/5276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I843cf483b93823cbcc5506958f62cbb076569ca8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
