Adar Dembo has posted comments on this change. Change subject: KUDU-1775 (part 1). Reject CREATE TABLE with negative or too-high replication factors ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5289/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 3764: TEST_F(ClientTest, TestCreateTableWithBadNumReplicas) { Would also be nice to test that, after changing the guard rail flag, we _can_ exceed the max. I guess this feedback also applies to your other guard rail patches. http://gerrit.cloudera.org:8080/#/c/5289/2/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 592: if (data_->num_replicas_ != boost::none) { Nothing wrong with using boost::optional here, but does this change fix a bug? I thought maybe this fixed the "negative replication factor" issue client-side, but if that were the case, num_replicas would not be greater than or equal to 1 and we wouldn't copy it to the CreateTableRequestPB. What am I missing? -- To view, visit http://gerrit.cloudera.org:8080/5289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83fedc7cb9722c049c20eb7766605fbb2f966347 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
