Hello Dan Burkert, Matthew Jacobs, Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5289
to review the following change.
Change subject: Reject CREATE TABLE with negative or too-high replication
factors
......................................................................
Reject CREATE TABLE with negative or too-high replication factors
This adds more master-side checking of the replication factor passed
from the client:
* must be non-negative. Previously passing a negative replication factor
would result in infinite retries trying to assign replicas.
* put an upper bound of 7, configurable with a new unsafe flag. We
haven't tested higher replication factors at all, and a
well-intentioned user may try to set replication factor to a very high
number to get a table replicated onto every server in their cluster.
This is common practice in MPP RDBMS, but since we haven't tested it,
we shouldn't allow it without making the user turn on
--unlock_unsafe_flags.
Change-Id: I83fedc7cb9722c049c20eb7766605fbb2f966347
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/experiments/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
7 files changed, 54 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/5289/1
--
To view, visit http://gerrit.cloudera.org:8080/5289
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83fedc7cb9722c049c20eb7766605fbb2f966347
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
