Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1773: remove overly strict DCHECKs ......................................................................
KUDU-1773: remove overly strict DCHECKs A tablet's replicas may change over the course of a write. For example, between two attempts at the same write, a replica could be evicted from the replication group and replaced by another. A pair of DCHECKs in the metacache didn't allow that, so they've been removed. Furthermore, their respective RemoteTablet functions now don't return anything, to reflect the fact that success or failure in finding the replica in question should be immaterial to all callers. Change-Id: I01c1dde99cce1f43e6a9864c1ff6f7aaad448a77 Reviewed-on: http://gerrit.cloudera.org:8080/5292 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h 2 files changed, 2 insertions(+), 15 deletions(-) Approvals: Mike Percy: Looks good to me, but someone else must approve Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01c1dde99cce1f43e6a9864c1ff6f7aaad448a77 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
