Haijie Hong has posted comments on this change. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates ......................................................................
Patch Set 8: (7 comments) > (7 comments) http://gerrit.cloudera.org:8080/#/c/5176/7/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: Line 165: uint32_t hash = partition_schema.BucketForEncodedColumns(encoded_string, hash_bucket_schema); > add an early return here so that the logic below can be outside the else bl Done Line 181: predicate->raw_values().end()); > I think this can be hoisted outside of the for loop. Done Line 194: new_encoded_string, > This means the has component is unconstrained, right? So does a full set a Done Line 295: // Step 2: Create the hash bucket portion of the partition key. > It could be more efficient to make this a vector<vector<bool>>, with the in Done Line 300: for (int hash_idx = 0; hash_idx < partition_schema.hash_bucket_schemas_.size(); hash_idx++) { > Given how much more expensive the hash partition search might be in terms o Done Line 309: can_prune = false; > this can be more efficient as Done Line 344: })); > given a `vector<bool>` representation, this if/else clause could be combine Done -- To view, visit http://gerrit.cloudera.org:8080/5176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578ac3c5e6770b13b0bebe01127d7d8263aceb36 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Haijie Hong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Haijie Hong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
