Haijie Hong has posted comments on this change. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates ......................................................................
Patch Set 13: (7 comments) > (9 comments) > > Sorry this took so long, was out on holiday break for a stretch. > Will try to be much more responsive going forward. Thanks again > for taking this on! http://gerrit.cloudera.org:8080/#/c/5176/12/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: Line 660: // a in [0, 1]; > We automatically simplify single-valued IN list predicates to an equality p Done http://gerrit.cloudera.org:8080/#/c/5176/12/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: Line 154: vector<bool> PartitionPruner::PruneHashComponent( > Move this comment to the header. Done PS12, Line 156: ema, : const Schema& schema, : const ScanSpec& scan_spec) { : vector<bool> hash_bucket_bitset(hash_bucket_schema.num_buckets, false); > To avoid the NOLINT you can add a line break before the first argument and Done PS12, Line 165: GetKeyEnc > Use FindOrDie, since the predicate has already been checked, and the result Done http://gerrit.cloudera.org:8080/#/c/5176/12/src/kudu/common/partition_pruner.h File src/kudu/common/partition_pruner.h: PS12, Line 67: combination of in-list and e > I think a better name for this method is 'PruneHashComponent', since it's b Done PS12, Line 67: // Sea > use the fully qualified std::vector in header files. Done Line 68: // Return hash values bitset of these combination. > See comment .cc about wrapping and NOLINT. Done -- To view, visit http://gerrit.cloudera.org:8080/5176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578ac3c5e6770b13b0bebe01127d7d8263aceb36 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Haijie Hong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Haijie Hong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
