Adar Dembo has posted comments on this change. Change subject: Add file globbing to Env ......................................................................
Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc File src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc: PS1, Line 74: pattern.ToString() > I haven't looked at the callers to CountFilesInDir(), but I presume the pat And I presume this is OK too (since it survived in PS2). http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1163: auto cleanup = MakeScopedCleanup([&] { globfree(&result); }); > Are you sure we should be calling this in the event of error too? Since you retained this in PS2 I presume it's safe. Line 1165: int ret = glob(path_pattern.c_str(), GLOB_TILDE | GLOB_ERR , NULL, &result); > Maybe GLOB_TILDE_CHECK so that if tilde substitution fails, it's an error? Don't think GLOB_TILDE_CHECK is a good idea? -- To view, visit http://gerrit.cloudera.org:8080/5338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic71160b11b19811ac9669dc7a572a7e4d2e59e79 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
