Dan Burkert has posted comments on this change. Change subject: Add file globbing to Env ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc File src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc: PS1, Line 74: > And I presume this is OK too (since it survived in PS2). It appears the answer is "no", so I reverted this part of the change. http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/util/env.h File src/kudu/util/env.h: PS1, Line 266: matchin > matching Done Line 268: virtual Status Glob(const std::string& path_pattern, std::vector<std::string>* paths) = 0; > error: no template named 'vector'; did you mean '__gnu_cxx::vector'? [clang Done http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1163: auto cleanup = MakeScopedCleanup([&] { globfree(&result); }); > Since you retained this in PS2 I presume it's safe. yes, it must be called in the event of an error. Line 1165: int ret = glob(path_pattern.c_str(), GLOB_TILDE | GLOB_ERR , NULL, &result); > Don't think GLOB_TILDE_CHECK is a good idea? GLOB_TILDE_CHECK is not defined on macOS. I tried to test GLOB_ERR on macOS, but it doesn't seem to do anything. -- To view, visit http://gerrit.cloudera.org:8080/5338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic71160b11b19811ac9669dc7a572a7e4d2e59e79 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
