Todd Lipcon has posted comments on this change.

Change subject: WIP: KUDU-798 (part 3) Replica transactions must start/abort on 
the consensus update thread
......................................................................


Patch Set 13:

(1 comment)

k, i like this approach more. BTW is there a later test in this series that 
validates that this does as it purports?

http://gerrit.cloudera.org:8080/#/c/5294/13/src/kudu/tablet/transactions/transaction_driver.cc
File src/kudu/tablet/transactions/transaction_driver.cc:

PS13, Line 381:   // Increase our ref count so that we're sure the driver 
survives until after we wait on the latch,
is this still needed?


-- 
To view, visit http://gerrit.cloudera.org:8080/5294
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie360e597eea86551c453717d7a1a000848027f4c
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to