Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1782. Fault injection crashes should exit with a specific exit code ......................................................................
KUDU-1782. Fault injection crashes should exit with a specific exit code This changes the fault injection "crash" to use exit(85) instead of LOG(FATAL). This means that we can now distinguish between a process exiting due to fault injection compared to a process exiting due to a crash or real FATAL-inducing issue. The WaitForCrash method in ExternalMiniCluster::ExternalDaemon is now split into WaitForInjectedCrash, which specifically checks that the exit code matches the expected one, and WaitForFatal, which checks that the exit code matches a SIGABRT. If the process exits with an unexpected status, a bad Status is returned, typically resulting in a test failure. I verified the new functionality by locally reverting back the fault injection code to use LOG(FATAL) and checking that ts_recovery-itest reported that the process had crashed unexpectedly. Change-Id: Ic8d9ae38efa65123ae69097a76c113b9709c3484 Reviewed-on: http://gerrit.cloudera.org:8080/5353 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/disk_reservation-itest.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/util/fault_injection.cc M src/kudu/util/fault_injection.h 8 files changed, 90 insertions(+), 31 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8d9ae38efa65123ae69097a76c113b9709c3484 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
