Adar Dembo has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util/async_logger.cc File src/kudu/util/async_logger.cc: PS4, Line 69: ull(*active > > BTW, Kudu should never Write() FATAL messages given that we aren't wrappi Ah, I forgot about that. Could you update the class doc to describe the flush semantics of glog in a little more detail, as I suggested above? http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util/async_logger.h File src/kudu/util/async_logger.h: PS4, Line 128: size = 0; : flush = false; > Sure, or 'needs_flush_or_write'. Were you going to rename this? -- To view, visit http://gerrit.cloudera.org:8080/5321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a0a29fa00a988a53a15d2c726ce5d49018f4d Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
