Todd Lipcon has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util/async_logger.cc File src/kudu/util/async_logger.cc: PS4, Line 69: force_flush > Makes sense; I didn't really understand what force_flush=true meant so I as > BTW, Kudu should never Write() FATAL messages given that we aren't wrapping > the FATAL-level logger, but defensively programming for AsyncLogger is a good > thing. Well, even though we don't wrap the FATAL destination, every FATAL message also gets written to the other log files (INFO, WARN, and ERROR) first. So, this actually has a positive effect (I verified without this code that the last INFO/WARNING messages could sometimes get chopped). -- To view, visit http://gerrit.cloudera.org:8080/5321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a0a29fa00a988a53a15d2c726ce5d49018f4d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
