Todd Lipcon has submitted this change and it was merged. Change subject: ssl_factory: avoid a non-POD (vector<>) in static storage ......................................................................
ssl_factory: avoid a non-POD (vector<>) in static storage The global vector<Mutex*> in static storage was causing ASAN test failures when I looped rpc-test's keepalive test with SSL enabled[1]. The issue is that the static storage destructor could run concurrently with other threads still trying to access the SSL mutexes. Since this mutex list is purposefully leaked anyway, it's better to just use a C-style array. [1] http://dist-test.cloudera.org/job?job_id=todd.1480910327.10622 Change-Id: I859aefd932d62fa8619650fcc795d3676187ceb4 Reviewed-on: http://gerrit.cloudera.org:8080/5354 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/net/ssl_factory.cc 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I859aefd932d62fa8619650fcc795d3676187ceb4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
