Mike Percy has posted comments on this change. Change subject: KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5357/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2693: return Substitute("TS $0 T $1: delete failed for tablet $2: $3", This is some pretty old code, I think. The error message prefix is a bit weird now, I think it would be better to stick with the "T <tablet> P <peer>" prefix which is standard elsewhere. Maybe something like: T 00000 P <master-uuid>: Delete of tablet <tablet-id> from peer <peer-uuid> failed due to <reason>: <error-string> (<TabletServerErrorPB::Code_Name()>) Line 2723: case TabletServerErrorPB::TABLET_NOT_RUNNING: Is the meaning of this code documented somewhere? -- To view, visit http://gerrit.cloudera.org:8080/5357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45f07667b6e62ce4814acfdf931dea2af4332d1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
