Adar Dembo has posted comments on this change. Change subject: KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors ......................................................................
Patch Set 1: (1 comment) Looks good. As we discussed, please try to build tests for this using tserver-side metrics to verify that DeleteTablet() RPCs aren't received once the master has figured out that it should stop. If anyone else has suggestions on how Dinesh could test this, please chime in! http://gerrit.cloudera.org:8080/#/c/5357/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2692: virtual string LogFailure(const string& reason, const Status& status) { Why is this method virtual? I don't see any overrides anywhere. -- To view, visit http://gerrit.cloudera.org:8080/5357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45f07667b6e62ce4814acfdf931dea2af4332d1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
