Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5363/2/src/kudu/integration-tests/tablet_copy_client_session-itest.cc File src/kudu/integration-tests/tablet_copy_client_session-itest.cc: PS2, Line 52: // We don't want the master to interfere when we forcibly make copies of : // tablets onto servers it doesn't know about. Only 2 servers. > Does this comment explain why master_tombstone_evicted_tablet_replicas=fals Yes, it refers to the master arguments. It is sort of out of place. I moved the comments around a bit. Line 65: workload.set_num_write_threads(8); > Why override the default value for this? Just to potentially write faster. I don't think it's very important, and I'll just remove this line. PS2, Line 70: while (workload.rows_inserted() < 10000) { : SleepFor(MonoDelta::FromMilliseconds(10)); : } > Why do we need to do this? We need to get some data written so that we can copy it. Added a comment. PS2, Line 88: StartSingleNode > Not sure this is an ideal name for the function; it's actually starting an Hard to do that. I gave it a more generic name but the doc comment above the method declaration provides the details. PS2, Line 109: std::numeric_limits<int32_t>::max() > Isn't this argument an int64_t though? Ah, yeah it's an int64_t. It's not optional... although frankly if it was I'm not sure if I would agree that passing it as such is better than just passing the value we want. Anyway, moot point :) -- To view, visit http://gerrit.cloudera.org:8080/5363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f3ec35885dbf1a81c23ac10b1c9556dfddbd4b7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
